Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor User parse_orderby and add user_registered support #2781

Merged
merged 2 commits into from
May 20, 2022
Merged

Refactor User parse_orderby and add user_registered support #2781

merged 2 commits into from
May 20, 2022

Conversation

felipeelia
Copy link
Member

Description of the Change

This PR refactors User::parse_orderby(), adds support for user_registered into that and also handles lowercase id as a sort clause.

Changelog Entry

Added: Support for ordering Users by user_registered and lowercase id.

Credits

Props @felipeelia @burhandodhy

@felipeelia felipeelia added this to the 4.2.0 milestone May 20, 2022
@felipeelia felipeelia self-assigned this May 20, 2022
tott
tott requested changes May 20, 2022
View reviewed changes
Copy link
Contributor

@tott tott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems wrong

includes/classes/Indexable/User/User.php Outdated Show resolved Hide resolved
tott
tott approved these changes May 20, 2022
View reviewed changes
Copy link
Contributor

@tott tott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me

@felipeelia felipeelia merged commit afba6b8 into develop May 20, 2022
@felipeelia felipeelia deleted the fix/users-orderby branch May 20, 2022 13:47
felipeelia added a commit that referenced this pull request May 20, 2022
@felipeelia
Add #2779, #2780, #2781, and #2782 to the changelog
6dcc826
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tott tott tott approved these changes

Assignees

@felipeelia felipeelia

Labels
None yet
Projects
None yet
Milestone
4.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@felipeelia @tott